Conversation
huchenlei
requested review from
a team,
DorotaLuna,
KarryCharon,
Yorha4D and
shinshin86
as code owners
Contributor
|
$100 as pre-selected option seems unnatural. What about going low to high? |
Contributor
|
On the contrary, if you are buying 100, you dont need to increment by 1 up and down. But if you buy 5, youre more likely to want to adjust by small margines. Additionaly, the primary action button is often for the action that is most common, rather than least common. |
Contributor
Author
|
Changed highlighted option to the 10$ option |
christian-byrne
pushed a commit
that referenced
this pull request
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
┆Issue is synchronized with this Notion page by Unito