Conversation
|
I think pad values (e.g. pixels) actually make more sense than the existing multiplier (pecentage). At the very least, have the multiplier capped by a static value (e.g. 100 px in canvas space). |
|
I'd prefer to avoid multiple incremental changes to the node default size; it's too disruptive. The goal here was to work around whatever got changed recently (<=1.16 -- can't recall when, but nodes now have larger min-width, so default size is huge). If the concern is an orphaned setting / setting overload, this might be better waiting until a fix for label sizes is implemented. |
The 1.16 change is caused by widget label also getting counted towards the width calculation because of widget input socket addition. Do you want to fix this on litegraph side instead if you just want the behavior to match pre1.16? i.e. filter out widget input sockets when calculating size. |
|
Yeah - already have a partial bit of work done on litegraph side for label size calc. But may be a "tomorrow" problem at this point. |
|
Widget label definitely should count towards size, but should be something like: Math.max(
largest input + largest output,
largest widget,
min node width
) |
|
@huchenlei Hard-coded to 60px for nodes, and only expands nodes that have widgets. With Comfy-Org/litegraph.js#962, nodes should behave pretty much as expected. |
2860cfe to
1e4bbd7
Compare
Co-authored-by: github-actions <github-actions@github.com>
Current
Nodes are created at 1.5x the minimum node width. This min value recently went up to prevent slot overlap, but this has resulted in huge default node sizes.
Proposed
For nodes without widgets, use the default Litegraph size, which now measures text. Add 60px to nodes with widgets, to ensure wide widgets show their value (rather than an ellipsis).
Adds a setting to disable the resize entirely.
┆Issue is synchronized with this Notion page by Unito