Skip to content

Fix opening search from context menu#3591

Merged
webfiltered merged 5 commits intomainfrom
context-then-search
Apr 23, 2025
Merged

Fix opening search from context menu#3591
webfiltered merged 5 commits intomainfrom
context-then-search

Conversation

@webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Apr 23, 2025

Resolves issue where search would not close or add a selected node, and simply added the node name to the bar.

Only occured when search was selected on the Litegraph add node context menu.

image

┆Issue is synchronized with this Notion page by Unito

Resolves issue where search would not close or add a selected node, and simply added the node name to the bar.

Only occured when search was selected on the Litegraph add node context menu.
@webfiltered webfiltered marked this pull request as ready for review April 23, 2025 20:59
@webfiltered webfiltered requested a review from a team as a code owner April 23, 2025 20:59
@webfiltered webfiltered added the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Apr 23, 2025
@webfiltered webfiltered requested a review from a team as a code owner April 23, 2025 21:19
@webfiltered webfiltered added the New Browser Test Expectations New browser test screenshot should be set by github action label Apr 23, 2025
@webfiltered webfiltered removed the New Browser Test Expectations New browser test screenshot should be set by github action label Apr 23, 2025
@webfiltered webfiltered merged commit 2ef8b7c into main Apr 23, 2025
9 of 10 checks passed
@webfiltered webfiltered deleted the context-then-search branch April 23, 2025 21:54
@webfiltered
Copy link
Contributor Author

Test failure: expected, manually checked. CI will be updated after version bump.

christian-byrne pushed a commit that referenced this pull request May 20, 2025
Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: When looking for nodes in the search the selected option got set as "filter" rather then being a node itself

1 participant