Load workflows from mp4/mov files#3543
Merged
christian-byrne merged 7 commits intomainfrom Apr 26, 2025
Merged
Conversation
christian-byrne
commented
Apr 21, 2025
huchenlei
approved these changes
Apr 21, 2025
christian-byrne
commented
Apr 26, 2025
Comment on lines
+1320
to
+1326
| } else if ( | ||
| file.type === 'video/mp4' || | ||
| file.name?.endsWith('.mp4') || | ||
| file.name?.endsWith('.mov') || | ||
| file.name?.endsWith('.m4v') || | ||
| file.type === 'video/quicktime' || | ||
| file.type === 'video/x-m4v' |
Contributor
Author
There was a problem hiding this comment.
In future: refactor this entire section of app.ts that conditionally handles dropped files based on type/extension. It is repeating same logic for every file type and the number of supported output types if increasing
christian-byrne
added a commit
that referenced
this pull request
May 20, 2025
Co-authored-by: github-actions <github-actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3538 by supporting loading workflows from mp4 files. Also allows parsing .mov and .m4v, should they later be created as outputs by ComfyUI or custom nodes.
The MP4 file format was originally based on the QuickTime File Format (.mov), later evolving to MP4 v2 as MPEG-4, then finally generalized into the ISO base media file format (ISOBMFF). This created a broader standard used as the foundation for multiple container formats, including modern .mov and related types like .m4v (often used for MP4 video within Apple ecosystems). ISOBMFF is a container file format that "defines a general structure for files that contain time-based multimedia data such as video and audio."
To embed metadata from the python side, use the following approach:
┆Issue is synchronized with this Notion page by Unito