Merged
Conversation
Contributor
Author
|
Better approach: keep a setting field for the background image, show some sort of visual indication of how to "unset" the background if it was set form the queue right click context menu. |
christian-byrne
requested review from
a team,
DorotaLuna,
KarryCharon,
Yorha4D and
shinshin86
as code owners
christian-byrne
force-pushed
the
output-to-bg
branch
from
218d610 to
8e8eeb4
Compare
Contributor
Author
|
Changes:
Demo: set-as-background-v2-demo-.mp4Let's merge this! |
webfiltered
reviewed
May 20, 2025
Contributor
webfiltered
left a comment
webfiltered
left a comment
There was a problem hiding this comment.
Have you noticed any performance issues? Specifically with a large busy graph, or zooming in on a long link?
Not extremely concerned, just want to make sure there aren't any single-digit FPS issues popping up from the transparent canvas.
Contributor
Author
|
Good question, let me test a bit and report back. |
Contributor
Author
|
After testing some images of various sizes, I was not able to find any scenarios with noticeable performance differences compared with default background. |
huchenlei
approved these changes
May 21, 2025
christian-byrne
added a commit
that referenced
this pull request
May 22, 2025
Co-authored-by: github-actions <github-actions@github.com>
lordTyrion
pushed a commit
to playbook3d/ComfyUI_frontend
that referenced
this pull request
Jul 2, 2025
Co-authored-by: github-actions <github-actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
output-as-bg.mp4
Needs discussion.
It's become considerably more difficult to set custom BG image since change to shipping comfy frontend as a pypi package.
┆Issue is synchronized with this Notion page by Unito