Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix vite config condition #2235

Merged
merged 3 commits into from
Jan 12, 2025
Merged

[CI] Fix vite config condition #2235

merged 3 commits into from
Jan 12, 2025

Conversation

christian-byrne
Copy link
Collaborator

@christian-byrne christian-byrne commented Jan 12, 2025

Enables sentry in release workflow. By mistake, the current condition is false in all actions runner envs:

!(
  process.env.CI === 'true' ||
  process.env.NODE_ENV === 'development' ||
  !process.env.SENTRY_DSN
)

The condition in this PR will be false in all actions runner envs except those that set SENTRY_DSN, which includes only the release workflow:

!(process.env.NODE_ENV === 'development' || !process.env.SENTRY_DSN)

Ref:

┆Issue is synchronized with this Notion page by Unito

@christian-byrne christian-byrne requested a review from a team as a code owner January 12, 2025 19:35
@huchenlei huchenlei merged commit c50a86b into main Jan 12, 2025
10 checks passed
@huchenlei huchenlei deleted the release-wf-env-var branch January 12, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants