Skip to content

Possible Memory Leak in Settings Panel #5163

@benceruleanlu

Description

@benceruleanlu

Prerequisites

  • I am running the latest version of ComfyUI
  • I have searched existing issues to make sure this isn't a duplicate
  • I have tested with all custom nodes disabled (see how)

What happened?

If you repeatedly open and close certain UI elements, I've only tested the settings panel and workflow templates view, they consistently increase the JS heap even after several GC runs.

Steps to Reproduce

  1. Go to performance tab on chrome devtools
  2. Enable viewing memory
  3. Start recording/profiling
  4. Click and click out of settings menu or workflow templates
  5. Click collect garbage
  6. Stop recording
  7. See that memory never goes back to original starting baseline

Or do a similar thing in the memory panel, seeing the detached DOM elements

How is this affecting you?

Minor inconvenience

ComfyUI Frontend Version

Stable 1.23.4 and nightly 1.26.6

Browser

Chrome/Chromium

Console Errors

Logs

Additional Context

Most apparent with the workflow templates view

Click to view screenshots Image Image

traces timelines and snapshots were too big to upload :(

┆Issue is synchronized with this Notion page by Unito

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions