[Feature Request]: Enable subgraphs to be expanded back to original nodes

[moontango]

Is there an existing issue for this?

• I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

Currently there appears to be no way to undo a "Convert to Graph".

It would be very nice to have that, e.g. use cases:

1. To add or remove nodes
2. Just undo mistakes

Proposed workflow

1. Rightclick the Subgraph node in the workflow
2. Select "Expand to Nodes"
3. All the groups and nodes automatically uncovert itself back to the original nodes, with all respective links intact.

Additional information

No response

┆Issue is synchronized with this Notion page by Unito

[comfyui-wiki]

This is a known issue. There was already related feedback in the early test. I think it will be fixed in the final release

[without-ordinary]

The only way I've found to undo currently is to use copy and paste the contents of the subgraph back to the parent graph.

I don't like to using node copy-paste as its pretty buggy on Linux+Firefox and almost always results in a bunch of duplicate nodes from an old workflow getting inserted off-screen in to a workflow many hours later.

[webfiltered]

its pretty buggy on Linux+Firefox and almost always results in a bunch of duplicate nodes from an old workflow getting inserted off-screen

To be honest, that sounds like a much bigger problem than expanding subgraphs. Is there already an issue open for that?

[without-ordinary]

its pretty buggy on Linux+Firefox and almost always results in a bunch of duplicate nodes from an old workflow getting inserted off-screen

To be honest, that sounds like a much bigger problem than expanding subgraphs. Is there already an issue open for that?

Don't know. Repo is super inconsistent, more so since I active avoid that conditions to cause it (ever putting and nodes on the clipboard), and it takes literally hours or days before it starts to occur out of nowhere. I can tell the age of the fragments being duplicated by their content, and the weirdest part is that they are frequently things that were never on the clipboard at any point.

My best guess at a cause is related to the whole middle click to paste on Linux and Comfyui using middle click for pan. I have middle click paste disabled within my desktop environment and within Firefox as I find that massively annoying. That fixes the Comfyui clipboard dropping a paste on every pan.

It's a very infrequent bug since the new front end. Last repo I encountered was around a month ago. Possibly in encouraging it less recently it's because I have to reload Comfyui 's webui often due to decreasing performance over the last few months.

I typically don't have the few hours free needed to fill out the bug report form on here. Just characterize a bug can take up all of the little free time for dev I get.

[LevelPixel]

To be honest, that sounds like a much bigger problem than expanding subgraphs. Is there already an issue open for that?

There is another, probably related issue:
There is still a problem with the clipboard when using other keyboard layouts and languages.
For example, if you copy (CTRL+C) and paste (CTRL+V) selected nodes in Russian, you will get duplicates of the copied nodes superimposed on each other. Sometimes even previous copied nodes are pasted.

Everything works fine on the English layout.

[LevelPixel]

3. All the groups and nodes automatically uncovert itself back to the original nodes, with all respective links intact.

Yes, that is the key expectation for the behavior of subgraphs. They should "expand" back when the user wants to do so, PRESERVING all connections that were made to the subgraph node.

Copying and pasting is not the expected behavior and is problematic (we need connect all pins again... not cool).

Also, CTRL+Z (Undo) should work for both Convert to Subgraph and Expand to Nodes operations. The same goes for Redo (CTRL+Y).

[webfiltered]

In order for this feature to be considered, we need to know why it is desired. So far, the only people who have provided answers to this wanted it for reasons that were only relevant to the old group nodes.

I'm not against adding this feature, but it would add a significant amount of code, and ongoing maintenance.

[without-ordinary]

I can foresee wanting to unsubgraph. The main common one being accidental creation.

Right now if I misclick (very easy on a touch interface or just if the tremors are bad), the only way to undo is to open the sub graph, copy and paste everything back to the main graph, and manually reconnect every link.

[webfiltered]

Does undo not work for you..?

[LaVie024]

Does undo not work for you..?

Firstly, the precedent was set with Group Nodes being able to do this. If subgraphs are to be a successor, they ought to have the same functionality as group nodes, just expanded.

Secondly, consider the cases as to why you would want to do this. What if you opened up a workflow, and needed to break out some of the subgraphs? What if you made plenty of changes, needed to see how some things connected together, or redo a few subgraphs, and your undo history does not stretch that far enough to revert to the point before said subgraph was made?

Is it not hard to make it such that it just gets the information of all the nodes in the subgraph, taking note of their connections, so that they can more easily be broken out?

[webfiltered]

Group nodes required that workaround because they could not be edited. So implementing the same for edit-friendly subgraphs requires entirely different justification. Let's focus on the actual use cases, please.

So far, it sounds like the only use for this as a feature is for fundamentally restructuring a workflow that contains subgraphs. Is that accurate, or are there more needs?