Fix vae load with --cpu-vae with AMD GPU#9751
Closed
N00byKing wants to merge 1 commit intoComfy-Org:masterfrom
Closed
Fix vae load with --cpu-vae with AMD GPU#9751N00byKing wants to merge 1 commit intoComfy-Org:masterfrom
N00byKing wants to merge 1 commit intoComfy-Org:masterfrom
Conversation
Member
|
This is a cleaner way of fixing this: #9754 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running on AMD and using
--cpu-vae,amd_min_versionlater in the code will cause a check ondevice, leading toExpected a cuda device, but got: cpu.is_amddoes not catch this because the actual generation is happening on an AMD GPU.This change mitigates this by always returning float32 if vae is done on CPU.
There may be cleaner ways to fix this; I am open to opinions on the matter.