Skip to content

Fix vae load with --cpu-vae with AMD GPU#9751

Closed
N00byKing wants to merge 1 commit intoComfy-Org:masterfrom
N00byKing:master
Closed

Fix vae load with --cpu-vae with AMD GPU#9751
N00byKing wants to merge 1 commit intoComfy-Org:masterfrom
N00byKing:master

Conversation

@N00byKing
Copy link

When running on AMD and using --cpu-vae, amd_min_version later in the code will cause a check on device, leading to Expected a cuda device, but got: cpu. is_amd does not catch this because the actual generation is happening on an AMD GPU.

This change mitigates this by always returning float32 if vae is done on CPU.
There may be cleaner ways to fix this; I am open to opinions on the matter.

@comfyanonymous
Copy link
Member

This is a cleaner way of fixing this: #9754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants