Memory estimation code can now take into account conds.#8307
Merged
comfyanonymous merged 1 commit intomasterfrom May 27, 2025
Merged
Memory estimation code can now take into account conds.#8307comfyanonymous merged 1 commit intomasterfrom
comfyanonymous merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible for the memory estimation to be based on specific conds for models instead of only the shape of the noise.
This for model_base.py:
self.memory_usage_factor_conds, which conds to use in the memory estimation.
def extra_conds_shapes(self, **kwargs), this function is the extra_conds function but returns shapes only.
memory_required now has a cond_shapes parameter.