Code Optimization and Issues Fixes in ComfyUI server#8196
Merged
comfyanonymous merged 2 commits intoComfy-Org:masterfrom May 21, 2025
Merged
Code Optimization and Issues Fixes in ComfyUI server#8196comfyanonymous merged 2 commits intoComfy-Org:masterfrom
comfyanonymous merged 2 commits intoComfy-Org:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two issues in the ComfyUI server code:
f.close()from thewith open(...) as f:blockChanges
f.close()from thewith open(...) as f:blockThe with statement (context manager) is designed to ensure that resources (such as file handles) are properly freed at the end of a code block (e.g., by calling its exit method, which for file objects would normally call close()). So f.close() is not necessary in this case
Testing Done
Verified that: