Add Help Menu in NodeLibrarySidebarTab#8179
Add Help Menu in NodeLibrarySidebarTab#8179comfyanonymous merged 11 commits intoComfy-Org:masterfrom
Conversation
Include HELP in node_info Include HELP in ComfyNodeABC Readd image to BFL Ultra Move images to backend
benceruleanlu
requested review from
Kosinkadink,
christian-byrne,
comfyanonymous,
huchenlei,
ltdrdata,
pythongosssss,
robinjhuang,
webfiltered and
yoland68
as code owners
|
The HELP variable should also accept URL endpoints to dynamically load HTML/MD so that nothing needs to be hard-coded (help info). |
|
Looks good on the backend PR 👍 Not sure if we should make the logging message be in a similar format as the other 'missing packages' ones, but I see why you have gone with the approach you did since technically missing the docs dep is not critical. |
|
BTW, before merge, version would have to be bumped to whatever is latest, even 0.1.0 is out of date RN. |
Kosinkadink
left a comment
Kosinkadink
left a comment
There was a problem hiding this comment.
Looks good, we'll just need to sync release with frontend PR once the conflicts are resolved: Comfy-Org/ComfyUI_frontend#3922
webfiltered
left a comment
webfiltered
left a comment
There was a problem hiding this comment.
@Kosinkadink It looks like this can be merged ahead of time - do we need to sync frontend release?
| except ImportError: | ||
| logging.info("comfyui-embedded-docs package not found") | ||
| return None |
There was a problem hiding this comment.
Should this have a catch-all that logs and returns? An unhandled exception type here would terminate app start.
There was a problem hiding this comment.
This should be fine - it matches the other import checks in frontend_management; our code checks the return value of this func so it shouldn't be an issue. Assuming the frontend PR handles docs static path not existing, of course:
There was a problem hiding this comment.
And yep, we can definitely merge it head of time.
5 participants
This PR adds a route to serve static web assets from the comfyui-embedded-docs python package.
Related Frontend PR: Comfy-Org/ComfyUI_frontend#3922
Related Docs PR: Comfy-Org/docs#120