Fix bug: don't retry request if API reports task failure#8111
Merged
comfyanonymous merged 1 commit intoComfy-Org:masterfrom May 14, 2025
Merged
Fix bug: don't retry request if API reports task failure#8111comfyanonymous merged 1 commit intoComfy-Org:masterfrom
comfyanonymous merged 1 commit intoComfy-Org:masterfrom
Conversation
christian-byrne
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue in which the polling retry logic is triggered when the API reports the task has failed.
This code:
https://github.com/comfyanonymous/ComfyUI/blob/98ff01e1486353a3b0ddd8fa82fcbb25401f8364/comfy_api_nodes/apis/client.py#L1074-L1077
raises exception, which is caught by the
exceptat bottom ofwhileblock, meant for catching network-related errors. There is a counter that is incremented for consecutive errors to prevent this, but it is reset to 0 since the response technically succeeded (successful response of API reporting that the task failed on their end).