Display progress and result URL directly on API nodes #8102
Merged
comfyanonymous merged 3 commits intoComfy-Org:masterfrom May 14, 2025
Merged
Display progress and result URL directly on API nodes #8102comfyanonymous merged 3 commits intoComfy-Org:masterfrom
comfyanonymous merged 3 commits intoComfy-Org:masterfrom
Conversation
75d49cb to
cc50a44
Compare
Contributor
Author
|
Wait a moment, the cherry picking was incorrect |
…Comfy-Org#177) [Veo] Print download URL of successful task result directly on nodes (Comfy-Org#184) [Recraft] Print download URL of successful task result directly on nodes (Comfy-Org#183) [Pixverse] Print download URL of successful task result directly on nodes (Comfy-Org#182) [Kling] Print download URL of successful task result directly on nodes (Comfy-Org#181) [MiniMax] Print progress text and download URL of successful task result directly on nodes (Comfy-Org#179) [Docs] Link to docs in `API_NODE` class property type annotation comment (Comfy-Org#178) [Ideogram] Print download URL of successful task result directly on nodes (Comfy-Org#176) [Kling] Print download URL of successful task result directly on nodes (Comfy-Org#181) [Veo] Print download URL of successful task result directly on nodes (Comfy-Org#184) [Recraft] Print download URL of successful task result directly on nodes (Comfy-Org#183) [Pixverse] Print download URL of successful task result directly on nodes (Comfy-Org#182) [MiniMax] Print progress text and download URL of successful task result directly on nodes (Comfy-Org#179) [Docs] Link to docs in `API_NODE` class property type annotation comment (Comfy-Org#178) [Luma] Print download URL of successful task result directly on nodes (Comfy-Org#177) [Ideogram] Print download URL of successful task result directly on nodes (Comfy-Org#176) Show output URL and progress text on Pika nodes (Comfy-Org#168) [BFL] Print download URL of successful task result directly on nodes (Comfy-Org#175) [OpenAI ] Print download URL of successful task result directly on nodes (Comfy-Org#174)
cc50a44 to
c8ea025
Compare
Contributor
Author
|
Fixed test failure that doesn't occur in 3.12: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For all API nodes that return a download URL, display the URL directly on the node as soon as it is available. This can benefit users who use an API node to generate something successfuly, but an error occurs before they can see the result in the queue sidebar or downstream save node. If the user does not have access to the logs for whatever reason, this may be their only recourse when encountering an error.
Examples:
See how it looks for all API nodes by opening this zip which contains test results from running with all relevant API nodes.