Skip to content

Normalize extra_model_config.yaml paths to prevent duplicates.#6885

Merged
comfyanonymous merged 3 commits intomasterfrom
rh-paths
Feb 20, 2025
Merged

Normalize extra_model_config.yaml paths to prevent duplicates.#6885
comfyanonymous merged 3 commits intomasterfrom
rh-paths

Conversation

@robinjhuang
Copy link
Member

@robinjhuang robinjhuang commented Feb 19, 2025

Currently if you have this as your extra_model_paths.yaml, ComfyUI will try to add
/path/to/ComfyUI/custom_nodes/ to folder_paths, which is not differentiated from /path/to/ComfyUI/custom_nodes without the trailing /.

comfyui:
  custom_nodes: custom_nodes/
  base_path: /path/to/ComfyUI

This causes ComfyUI to import custom nodes twice.

Import times for custom nodes:
   0.0 seconds: /Users/../Desktop/custom_nodes/aigodlike-comfyui-translation
   0.0 seconds: /Users/../Desktop/custom_nodes/aigodlike-comfyui-translation

https://forum.comfy.org/t/when-installing-the-translation-plugin-through-manager-an-error-occurs-after-deleting-the-translation-plugin-it-can-be-opened/1549/6

webfiltered
webfiltered previously approved these changes Feb 19, 2025
Copy link
Contributor

@webfiltered webfiltered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/tests

@comfyanonymous comfyanonymous merged commit 29d4384 into master Feb 20, 2025
6 checks passed
@robinjhuang robinjhuang deleted the rh-paths branch March 11, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants