remove light_intensity and fov from load3d#6742
Merged
comfyanonymous merged 1 commit intoComfy-Org:masterfrom Feb 15, 2025
Merged
remove light_intensity and fov from load3d#6742comfyanonymous merged 1 commit intoComfy-Org:masterfrom
comfyanonymous merged 1 commit intoComfy-Org:masterfrom
Conversation
jtydhr88
requested review from
Kosinkadink,
huchenlei,
ltdrdata,
pythongosssss,
robinjhuang and
yoland68
as code owners
Contributor
Author
|
close for now |
Contributor
Author
|
reopen for Comfy-Org/ComfyUI_frontend#2492 |
huchenlei
approved these changes
Feb 15, 2025
Contributor
|
@comfyanonymous Please merge this pr as frontend change is active now in 1.9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove two params from node panel and moved them to scene, this is BE change for Comfy-Org/ComfyUI_frontend#2464