[Security] Fix potential XSS on /view#6034
Merged
comfyanonymous merged 1 commit intomasterfrom Dec 13, 2024
Merged
Conversation
Member
|
Works as expected on my machine - downloads the .html file instead of running it. Not sure how much effort it would be, but is the api/upload/image endpoint expected to allow non-image types to be uploaded as well, or can it be modified to not allow .html uploads? The xss here at its core is the stored/persistent kind, so getting rid of the .html being uploaded in the first place would prevent the vulnerability from being exploited by another endpoint in the future. |
Member
|
For archiving purposes, here is the vulnerability this PR aims to resolve: https://nvd.nist.gov/vuln/detail/CVE-2024-10099 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents html/htm/js/css files being served as web page for code execution.
Reproduction steps
ComfyUI/outputfolderhttp://localhost:8188/api/view?filename=index.html&type=output&subfolder=in browser nav barNote
During testing, make sure that you disable browser cache between different testing procedures.