Skip to content

Fix/webp exif little endian #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
comfyanonymous merged 2 commits into from
Jul 19, 2024
Merged

Fix/webp exif little endian #4061

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d3db79
Fix for isLittleEndian flag in parseExifData.
greg-ww Jul 19, 2024
72fc452
Add break after reading first exif chunk in getWebpMetadata.
greg-ww Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web/scripts/pnginfo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export function getPngMetadata(file) {

function parseExifData(exifData) {
// Check for the correct TIFF header (0x4949 for little-endian or 0x4D4D for big-endian)
const isLittleEndian = new Uint16Array(exifData.slice(0, 2))[0] === 0x4949;
const isLittleEndian = String.fromCharCode(...exifData.slice(0, 2)) === "II";

// Function to read 16-bit and 32-bit integers from binary data
function readInt(offset, isLittleEndian, length) {
Expand Down Expand Up @@ -134,6 +134,7 @@ export function getWebpMetadata(file) {
let index = value.indexOf(':');
txt_chunks[value.slice(0, index)] = value.slice(index + 1);
}
break;
}

offset += 8 + chunk_length;
Expand Down