Skip to content

add hunyuan dit txt2image#3969

Closed
xuhuaren wants to merge 2 commits intoComfy-Org:masterfrom
xuhuaren:master
Closed

add hunyuan dit txt2image#3969
xuhuaren wants to merge 2 commits intoComfy-Org:masterfrom
xuhuaren:master

Conversation

@xuhuaren
Copy link

@xuhuaren xuhuaren commented Jul 8, 2024

three notes for hunyuan dit txt2image:
HunYuan Checkpoint Loader

  • Loads the base model for HunYuanDiT in ksampler backend.
  • model_name is the weight list of comfyui checkpoint folder.

HunYuan CLIP Loader

  • Loads the clip and mt5 model for HunYuanDiT in ksampler backend.
  • text_encoder_path is the weight list of comfyui clip model folder.
  • t5_text_encoder_path is the weight list of comfyui t5 model folder.

HunYuan VAE Loader

  • Loads the vae model for HunYuanDiT in ksampler backend.
  • model_name is the weight list of comfyui vae model folder.

@xuhuaren xuhuaren requested a review from comfyanonymous as a code owner July 8, 2024 02:10
Copy link
Contributor

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove .DS_Store system file. Thanks! You can add it to gitignore.

@pamparamm
Copy link
Contributor

pamparamm commented Jul 8, 2024

I don't think you should use /custom_nodes/ folder to add new features to the upstream and comment out /custom_nodes/ from .gitignore file - this can and will cause problems with other custom nodes.

You should either refactor this code similar to SD1.5/SDXL/SD3 implementation and place it into /comfy/ folder or turn it into a custom extension and make a separate repository (just like any custom node).

@mcmonkey4eva mcmonkey4eva marked this pull request as draft July 8, 2024 16:29
@xuhuaren
Copy link
Author

xuhuaren commented Jul 9, 2024 via email

@comfyanonymous
Copy link
Member

See: #4102

@comfyanonymous
Copy link
Member

All the functionality in this (base model + lora support) is implemented now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants