Closed
Conversation
huchenlei
reviewed
Jul 8, 2024
Contributor
huchenlei
left a comment
There was a problem hiding this comment.
Please remove .DS_Store system file. Thanks! You can add it to gitignore.
Contributor
|
I don't think you should use /custom_nodes/ folder to add new features to the upstream and comment out You should either refactor this code similar to SD1.5/SDXL/SD3 implementation and place it into /comfy/ folder or turn it into a custom extension and make a separate repository (just like any custom node). |
Author
|
I previously discussed with Yoland and Comfy about integrating HunyuanDIT
into ComfyUI. This would allow users to use HunyuanDIT directly by updating
ComfyUI. The idea was to modify the code to meet certain requirements and
then submit it through a PR. The administrator would then do the rest of
the work to integrate the code into ComfyUI.
…On Mon, Jul 8, 2024 at 8:27 PM Pam ***@***.***> wrote:
I don't think you should use /custom_nodes/ folder to add new features to
the upstream and comment out /custom_nodes/ from .gitignore file - this
can and will cause problems with other custom nodes.
Why add these custom nodes directly into ComfyUI when you can turn it into
a separate extension?
—
Reply to this email directly, view it on GitHub
<#3969 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZHK7L3BEBRZXNZRDZIBF3ZLKATNAVCNFSM6AAAAABKP4W6MWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJTHEZTSOJWGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
See: #4102 |
Member
|
All the functionality in this (base model + lora support) is implemented now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
three notes for hunyuan dit txt2image:
HunYuan Checkpoint Loader
HunYuan CLIP Loader
HunYuan VAE Loader