Conversation
Comfy Aimdo 0.2.2 moves the cuda allocator hook from the cudart API to the cuda driver API on windows. This is needed to handle Windows+cu13 where cudart is statically linked.
📝 WalkthroughWalkthroughThis pull request updates the 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Test Evidence CheckIf this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided. You can add it by:
|
Comfy Aimdo 0.2.2 moves the cuda allocator hook from the cudart API to the cuda driver API on windows. This is needed to handle Windows+cu13 where cudart is statically linked.
Before:
After:
Regression Tests:
For each of pyt 2.8+cu128 and pyt 2.12dev+cu130:
RTX5090, Linux, WAN 2.2 (multiple large models) ✅
RTX5090, Linux, Flux2 (linux offload) ✅
RTX5090, Linux, CPU@2GHZ Ace Step (CPU throttle) ✅
For each for pyt 2.8+cu128 and pyt2.10.0+cu130
Windows, RTX5060, WAN 2.1 640x400 ✅
Performance is roughly on par with non dynamic in the Windows WAN flow. A little faster (5-10s) on first runs due to load overlapping.