fix: Content-Disposition Header not matching RFC2183 rules

[artylobos]

What does this PR do?

Fixes #8914

/claim #8914

Description

This PR addresses the issue: Content-Disposition Header not matching RFC2183 rules

See #8914 for details.

Type of change

• Bug fix (non-breaking change which fixes an issue)

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b1c63e and b3d800c.

📒 Files selected for processing (1)

• server.py

---

📝 Walkthrough

Walkthrough

The PR modifies HTTP response headers in server.py for all image view responses. The Content-Disposition header is updated to include the inline directive alongside the filename parameter, whereas previously only the filename parameter was specified. This change applies to in-memory preview responses, channel-based output responses, and file-based responses. The modification consists of 4 lines added and 4 lines removed with no changes to underlying logic or control flow.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The PR changes the Content-Disposition header from filename="..." to inline; filename="..." format. However, RFC 2183 specifies the format should be attachment; filename="..." for downloads, not inline; filename="..." for inline display.	Change the Content-Disposition header format from 'inline; filename="..."' to 'attachment; filename="..."' to properly comply with RFC 2183 requirements for file downloads as specified in issue #8914.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: fixing the Content-Disposition header to match RFC2183 rules, which aligns with the changeset.
Description check	✅ Passed	The description references the linked issue #8914 and explains that the PR addresses RFC 2183 compliance for the Content-Disposition header, which directly relates to the changeset.
Out of Scope Changes check	✅ Passed	All changes are limited to modifying the Content-Disposition header format in HTTP responses, which is directly scoped to the linked issue #8914 requirements.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[isaac-mcfadyen]

This is a duplicate of #12535 which itself is a duplicate of many other PRs.