Skip to content

fix: move essentials_category to correct replacement nodes#12568

Open
christian-byrne wants to merge 1 commit intomasterfrom
fix-essentials-category-assignments
Open

fix: move essentials_category to correct replacement nodes#12568
christian-byrne wants to merge 1 commit intomasterfrom
fix-essentials-category-assignments

Conversation

@christian-byrne
Copy link
Contributor

Summary

Move essentials_category assignments from deprecated/incorrect nodes to their proper replacements.

Changes

  • ImageBatch → BatchImagesNode: ImageBatch is deprecated; move essentials_category to its replacement BatchImagesNode
  • Blur (ImageBlur) → removed: Blur should use the subgraph blueprint GLSL shader instead of the native node
  • GetVideoComponents → Video Slice: Video Slice is the correct node for the Video Tools essentials category

Related frontend PR: Comfy-Org/ComfyUI_frontend#9072

Move essentials_category from deprecated/incorrect nodes to their replacements:
- ImageBatch → BatchImagesNode (ImageBatch is deprecated)
- Blur → removed (should use subgraph blueprint)
- GetVideoComponents → Video Slice

Amp-Thread-ID: https://ampcode.com/threads/T-019c8340-4da2-723b-a09f-83895c5bbda5
@coderabbitai
Copy link

coderabbitai bot commented Feb 22, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

The pull request reorganizes essentials_category metadata assignments across node definitions in three files. In comfy_extras/nodes_post_processing.py, the category is removed from ImageBlur and added to BatchImagesNode. In comfy_extras/nodes_video.py, the category is removed from GetVideoComponents and added to VideoSlice. Additionally, the ESSENTIALS_CATEGORY constant is removed from the ImageBatch class in nodes.py. These changes result in a net modification of +2 lines and -3 lines across the affected files.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: move essentials_category to correct replacement nodes' accurately summarizes the main change: reassigning essentials_category metadata from deprecated/incorrect nodes to their proper replacements.
Description check ✅ Passed The description clearly explains the changes: moving essentials_category from ImageBatch to BatchImagesNode, removing it from ImageBlur, and moving it from GetVideoComponents to VideoSlice, with context about deprecations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@christian-byrne christian-byrne added the Core Core team dependency label Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Core team dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants