Update nightly installation command for ROCm#12547
Conversation
Updated the nightly installation command for ROCm from 7.1 to 7.2.
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe change updates the ROCm version reference in README.md from rocm7.1 to rocm7.2 within the AMD Linux installation instructions. It modifies a single line in the installation documentation; no other commands, messages, code, or public API declarations were changed. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Around line 232-234: Update the stale prose that mentions "ROCm 7.1" so it
matches the pip command URL which uses "rocm7.2": find the sentence that
references "ROCm 7.1" near the pip command and change it to "ROCm 7.2" (ensure
the text and the command URL https://download.pytorch.org/whl/nightly/rocm7.2
are consistent).
README.md
Outdated
| This is the command to install the nightly with ROCm 7.1 which might have some performance improvements: | ||
|
|
||
| ```pip install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/rocm7.1``` | ||
| ```pip install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/rocm7.2``` |
There was a problem hiding this comment.
Stale description text still says "ROCm 7.1" after bumping the URL to rocm7.2.
Line 232 was not updated alongside the URL change on line 234, leaving the prose and the command out of sync.
📝 Proposed fix
-This is the command to install the nightly with ROCm 7.1 which might have some performance improvements:
+This is the command to install the nightly with ROCm 7.2 which might have some performance improvements:📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| This is the command to install the nightly with ROCm 7.1 which might have some performance improvements: | |
| ```pip install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/rocm7.1``` | |
| ```pip install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/rocm7.2``` | |
| This is the command to install the nightly with ROCm 7.2 which might have some performance improvements: | |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` around lines 232 - 234, Update the stale prose that mentions "ROCm
7.1" so it matches the pip command URL which uses "rocm7.2": find the sentence
that references "ROCm 7.1" near the pip command and change it to "ROCm 7.2"
(ensure the text and the command URL
https://download.pytorch.org/whl/nightly/rocm7.2 are consistent).
Updated the nightly installation command for ROCm from 7.1 to 7.2.