Conversation
|
Played around with it a bit, is it intended that the node be super picky about there being exactly the There is definitely use for the error guaranteeing a duration, but the imo the Video interface should also have a boolean input, Also might be nice to support a negative |
|
Negative start time is a good idea. I'll add support for it. I'll update the tooltip for duration to make it clear that 0 disables and investigate your suggestion. Allowing the option for duration less than requested would give closer parity to the VHS equivalent, Worst case, support for less strict duration can be added later without any forward compatibility risk. |
Kosinkadink
left a comment
There was a problem hiding this comment.
still looks good, merging
Introduces a new "Video Slice" node which allows for restricting a

VIDEOinput to a providedstart_timeandduration.Because remuxing videos requires that
start_timeis aligned to a keyframe, the existing implementation simply setsreuse_streamstoFalseto utilize the existing architecture. This could be improved in the future to instead stream the transcoding for reduced memory usage.Similarly, the
VideoFromComponentscreates a newVideoFromFilewith the trimming applied. Since the values forstart_timeanddurationare unlikely to align to an exact frame time, this ensures a subsequentsaveoperation can correctly trim the duration of the last frame and that multiple VideoSlice applied in a row will not accumulate rounding errors.