Propagate Qwen-Image attention mask to image generation.#11966
Merged
comfyanonymous merged 1 commit intoComfy-Org:masterfrom Jan 23, 2026
Merged
Conversation
Member
Test Evidence Check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
For optimization purposes, it is sometimes recommended to run model inference with inputs of a fixed size. This can be supported by padding the text tokens to a fixed length, with the padding information propagated to the diffusion model using an attention mask. This mechanism is implemented in ComfyUI for many models, but not for Qwen-Image.
What?
Running example
I used the template workflow for Qwen-Image-2512 (its lower part with 4-steps lightning LoRA) and changed only the positive prompt and the seed:
In order to add text tokens padding, I modified the initialization of
Qwen25_7BVLITokenizer(themin_lengthargument from 1 to 256) in text_encoders/qwen_image.The following grid presents the results with
min_length=1andmin_length=256, without and with this proposed fix; we can see that with the existing implementation, which does not pass the attention mask, the model attends to the padding tokens and the content of the image shifts dramatically, while my fix encourages a much subtler change.min_length = 1min_length = 256