Make database bulk_ops.py more widely compatible across sqlalchemy+python versions#11839
Merged
comfyanonymous merged 1 commit intomasterfrom Jan 13, 2026
Merged
Make database bulk_ops.py more widely compatible across sqlalchemy+python versions#11839comfyanonymous merged 1 commit intomasterfrom
comfyanonymous merged 1 commit intomasterfrom
Conversation
…d 3.11 sqlalchemy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was not able to reproduce on 3.10 or 3.11 as originally reported, there appears to be the chance that RETURNING is not supported by sqlite/sqlalchemy on these version of python: #11792
I changed bulk_ops to replace .returning with separate select and insert queries.