feat: add 'cancelled' status for interrupted jobs in /api/jobs#11680
Merged
Kosinkadink merged 1 commit intoComfy-Org:masterfrom Jan 9, 2026
Merged
feat: add 'cancelled' status for interrupted jobs in /api/jobs#11680Kosinkadink merged 1 commit intoComfy-Org:masterfrom
Kosinkadink merged 1 commit intoComfy-Org:masterfrom
Conversation
d44c234 to
2d39630
Compare
Kosinkadink
approved these changes
Jan 7, 2026
Member
|
Can I still comment? |
Contributor
Author
Go for it, what's up? |
Member
|
I think he was testing if things work after the transfer |
Contributor
Author
Makes sense. Can I merge this myself? Is there another step? |
Member
|
lets go to michigan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cancelledstatus to the/api/jobsendpoint for jobs that were interrupted/cancelled by the userstatus: 'failed', making it impossible to distinguish between themstatus: 'cancelled'while actual errors returnstatus: 'failed'Changes
JobStatus.CANCELLED = 'cancelled'constantnormalize_history_item()to detectexecution_interruptedmessages and returncancelledstatusget_all_jobs()to support filtering bycancelledstatusAPI Usage
Test plan
pytest tests/execution/test_jobs.py- 28/28 passing)status: 'cancelled'status: 'failed'🤖 Generated with Claude Code