fix(LoadImage): ignore broken MPO frames after first decoded image#11565
Closed
bigcat88 wants to merge 1 commit intoComfy-Org:masterfrom
Closed
fix(LoadImage): ignore broken MPO frames after first decoded image#11565bigcat88 wants to merge 1 commit intoComfy-Org:masterfrom
bigcat88 wants to merge 1 commit intoComfy-Org:masterfrom
Conversation
bigcat88
requested review from
Kosinkadink,
comfyanonymous and
guill
as code owners
bigcat88
force-pushed
the
fix/mpo-load
branch
from
ec7019a to
db60a1e
Compare
Contributor
Author
|
+label: Core |
Contributor
Author
|
-label: Core |
Member
|
Closing in favor of #11569 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pillow can raise
ValueError("No data found for frame")on some MPOs whenseeking a later frame with missing/invalid data. This prevented LoadImage
from returning the successfully decoded primary image.
We wrap iteration of the frames and if first frame is ok(only for
MPOformat), we ignore other decoding errors.Exception happens here: https://github.com/python-pillow/Pillow/blob/2ebb3e9964bcfb46e2b8dcaec1917caf67730a7d/src/PIL/MpoImagePlugin.py#L152-L155
Edited: Alternative PR was created with less changes and keeping the current logic.