add weight_scale_inv implementation#10930
Closed
yoinked-h wants to merge 3 commits intoComfy-Org:masterfrom
Closed
add weight_scale_inv implementation#10930yoinked-h wants to merge 3 commits intoComfy-Org:masterfrom
yoinked-h wants to merge 3 commits intoComfy-Org:masterfrom
Conversation
Contributor
Author
|
nevermind, solved by #10864 (except the utilization of sdnext keys which could be solved in the future) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
originates from sdnext, seems like a good idea (tldr: instead of one scale for a
.weight, make it apply to smaller subsets of the weight (see this for more info), currently only seen in qwen image since its really large; but could apply to most models