Skip to content

Hooks disabled at first step of a second SamplerCustomAdvanced node #6183

@catboxanon

Description

@catboxanon

Expected Behavior

Results are identical when a hook LoRA is enabled and multiple SamplerCustomAdvanced nodes are used.

Actual Behavior

Results are not identical when a hook LoRA is enabled and multiple SamplerCustomAdvanced nodes are used. They are only identical if no hook is used.

Steps to Reproduce

See workflow: hook-test.json

Any model and LoRA is usable to reproduce this issue.

1) Result using 1 SamplerCustomAdvanced node, with hooks

image

2) Result using 2 SamplerCustomAdvanced nodes, with hooks (expected to match with result 1)

image

3) Result using 1 or 2 SamplerCustomAdvanced nodes, without hooks (matches as expected)

image

The last result in this list can be obtained by bypassing the Set CLIP Hooks node. (Ctrl + B)

Debug Logs

n/a

Other

A use case of a workflow like this, though not shown in this workflow in order to keep things straightforward, would be to sample for a longer duration in high sigma values, or to flip the latent halfway through sampling.

I've also mentioned in this issue title that hooks seem disabled in the first step based on what the sampling preview produces, and also the brief lag after 1 step is performed in the second SamplerCustomAdvanced node (which does not occur when hooks are disabled).

Version info

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    Potential BugUser is reporting a bug. This should be tested.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions