TAEs stopped working

[10902940129041]

Custom Node Testing

• I have tried disabling custom nodes and the issue persists (see how to disable custom nodes if you need help)

Expected Behavior

TAE should load in Load VAE for decoding and encoding

Actual Behavior

UnboundLocalError: cannot access local variable 'metadata' where it is not associated with a value

Steps to Reproduce

Load VAE: taef1/taesd/taesdxl/taesd3

Debug Logs

!!! Exception during processing !!! cannot access local variable 'metadata' where it is not associated with a value
Traceback (most recent call last):
  File "/content/ComfyUI/execution.py", line 518, in execute
    output_data, output_ui, has_subgraph, has_pending_tasks = await get_output_data(prompt_id, unique_id, obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb, v3_data=v3_data)
                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/content/ComfyUI/execution.py", line 329, in get_output_data
    return_values = await _async_map_node_over_list(prompt_id, unique_id, obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb, v3_data=v3_data)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/content/ComfyUI/execution.py", line 303, in _async_map_node_over_list
    await process_inputs(input_dict, i)
  File "/content/ComfyUI/execution.py", line 291, in process_inputs
    result = f(**inputs)
             ^^^^^^^^^^^
  File "/content/ComfyUI/custom_nodes/ComfyUI-KJNodes/nodes/nodes.py", line 2410, in load_vae
    vae = VAE(sd=sd, device=device, dtype=dtype, metadata=metadata)
                                                          ^^^^^^^^
UnboundLocalError: cannot access local variable 'metadata' where it is not associated with a value

Other

Due to #11846

[rattus128]

This is actually a bug in KJNodes, but its heavily related to the change you linked so ill just tag @kijai directly. The code has separate if else logic for populating the metadata local and using it and im guessing your use case is able to get it inconsistent.

This is probably the fix (untested):

rattus@rattus-box2:~/comfy-base/custom_nodes/ComfyUI-KJNodes$ git diff nodes/nodes.py
diff --git a/nodes/nodes.py b/nodes/nodes.py
index d8f405d..c357662 100644
--- a/nodes/nodes.py
+++ b/nodes/nodes.py
@@ -2392,6 +2392,7 @@ class VAELoaderKJ:
 
     def load_vae(self, vae_name, device, weight_dtype):
         from comfy.sd import VAE
+        metadata=None
         dtype = {"bf16": torch.bfloat16, "fp16": torch.float16, "fp32": torch.float32}[weight_dtype]
         if device == "main_device":
             device = model_management.get_torch_device()

[kijai]

Yeah I missed that case, this does affect both the VAELoaderKJ and the core VAELoader as well.

Fixed it in the KJNodes and also created a PR to the native VAE loader.

[10902940129041]

I thought it wasn't related to KJNodes because I fixed it by using git reset. Thanks