Skip to content

fix(ui): hide Share button in new menu when share_option is none - #3140

Open
hcwhan wants to merge 1 commit into
Comfy-Org:mainfrom
hcwhan:fix/hide-share-button-when-none
Open

fix(ui): hide Share button in new menu when share_option is none#3140
hcwhan wants to merge 1 commit into
Comfy-Org:mainfrom
hcwhan:fix/hide-share-button-when-none

Conversation

@hcwhan

@hcwhan hcwhan commented Aug 7, 2026

Copy link
Copy Markdown

Summary

  • Hide the Share button in the new-style ComfyButtonGroup menu when share_option is none
  • Use conditional array spread so the button is omitted instead of rendered and left non-functional

Motivation

The share settings combo documents that none should hide the Share button in the main menu. The legacy menu already implements this (shareButton.style.display = "none"), but the new-style menu always included the Share ComfyButton.

This change makes both UI paths respect the same setting.

Test plan

  • Set share option to none in Manager settings: Share button hidden in new-style menu
  • Set share option to openart / all / etc.: Share button visible and works as before
  • Legacy menu Share button behavior unchanged

The legacy menu already hides the Share button when share_option is set
to none. Apply the same behavior to the new ComfyButtonGroup menu so the
setting is respected consistently across UI styles.
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b4c23846-3305-4776-96a2-9cf4eb766f41

📥 Commits

Reviewing files that changed from the base of the PR and between 4814b5d and 5c761c3.

📒 Files selected for processing (1)
  • js/comfyui-manager.js

📝 Walkthrough

Walkthrough

The new-style menu now shows the Share button only when share_option is not 'none'. The existing Share action and tooltip remain unchanged.

Changes

Share menu behavior

Layer / File(s) Summary
Conditional Share button
js/comfyui-manager.js
The menu omits the Share button when share_option === 'none'. It preserves the existing action and tooltip for other values. A tiny toggle, neatly in control.
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant