fix(ui): hide Share button in new menu when share_option is none - #3140
Open
hcwhan wants to merge 1 commit into
Open
fix(ui): hide Share button in new menu when share_option is none#3140hcwhan wants to merge 1 commit into
hcwhan wants to merge 1 commit into
Conversation
The legacy menu already hides the Share button when share_option is set to none. Apply the same behavior to the new ComfyButtonGroup menu so the setting is respected consistently across UI styles.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe new-style menu now shows the Share button only when ChangesShare menu behavior
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ComfyButtonGroupmenu whenshare_optionisnoneMotivation
The share settings combo documents that
noneshould hide the Share button in the main menu. The legacy menu already implements this (shareButton.style.display = "none"), but the new-style menu always included the ShareComfyButton.This change makes both UI paths respect the same setting.
Test plan
nonein Manager settings: Share button hidden in new-style menuopenart/all/ etc.: Share button visible and works as before