Fix Request method for multipart/form-data used in AdminMetaResourceNew#5
Open
aneesh-n wants to merge 2 commits intoCometBackup:mainfrom
Open
Fix Request method for multipart/form-data used in AdminMetaResourceNew#5aneesh-n wants to merge 2 commits intoCometBackup:mainfrom
aneesh-n wants to merge 2 commits intoCometBackup:mainfrom
Conversation
Contributor
Author
|
If we can add a license as a secret, we could potentially set up a test suite for this project with a dockerized server. |
Contributor
|
Hi @aneesh-n, thanks again for another great PR. We have reproduced the issue internally and are figuring out our next steps from here. Just for comparison, the Comet PHP SDK had identified this AdminMetaResourceNew API as an edge case, and had added an explicit unit test for it: https://github.com/CometBackup/comet-php-sdk/blob/master/tests/ExampleTest.php#L215 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't able to get
AdminMetaResourceNewto work with the Request method in its current form. I kept getting - "Error returned from API (code 500): Internal error".Had to modify the Request method to use
m.CreateFormFileandhttp.NewRequestwhen"multipart/form-data"is used ascontentType.As a result
AdminMetaResourceNewnow expects"upload"input to be a path to the file instead of the file content.If there is another way to get AdminMetaResourceNew to work in the current form, we can close this PR.