Conversation
amanmahajan7
approved these changes
Feb 24, 2026
| const initialHorizontalScrollbarHeight = offsetHeight - clientHeight; | ||
| const initialWidth = width - offsetWidth + clientWidth; | ||
| const initialHeight = height - initialHorizontalScrollbarHeight; | ||
| const { clientWidth, clientHeight } = gridRef.current!; |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3980 +/- ##
=======================================
Coverage ? 97.53%
=======================================
Files ? 36
Lines ? 1463
Branches ? 472
=======================================
Hits ? 1427
Misses ? 36
Partials ? 0
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed
--rdg-scroll-height, we can rely onmax-content, orcalc-size()in more complex scenarios.The resize observer callback now only reads from
contentBoxSize,no access to
clientHeight/offsetHeight-> no chance to thrash layout.I've also simplified initial width/height states, it works fine in basic testing, but if the browser zoom isn't exactly 100% then the dimensions will be wrong anyway.
Maybe it's best to wait for the RO callback?