Move row focus logic to <TreeGrid />, add renderSummaryRow#3976
Open
amanmahajan7 wants to merge 5 commits intomainfrom
Open
Move row focus logic to <TreeGrid />, add renderSummaryRow#3976amanmahajan7 wants to merge 5 commits intomainfrom
<TreeGrid />, add renderSummaryRow#3976amanmahajan7 wants to merge 5 commits intomainfrom
Conversation
amanmahajan7
changed the title
renderSummaryRow<TreeGrid />, add renderSummaryRow
amanmahajan7
commented
Feb 23, 2026
| isTreeGrid: boolean; | ||
| } | ||
|
|
||
| export interface RenderSummaryRowProps<TRow, TSummaryRow = unknown> extends Pick< |
Collaborator
Author
There was a problem hiding this comment.
Should we extend div props?
| isRowSelectionDisabled: _isRowSelectionDisabled, | ||
| ...props | ||
| }: GroupRowRendererProps<R, SR>) { | ||
| const isPositionOnRow = selectedCellIdx === -1; |
Collaborator
Author
There was a problem hiding this comment.
I removed it for now as we do not focus on the header row
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3976 +/- ##
=======================================
Coverage 97.54% 97.55%
=======================================
Files 36 36
Lines 1467 1471 +4
Branches 472 473 +1
=======================================
+ Hits 1431 1435 +4
Misses 36 36
🚀 New features to boost your workflow:
|
nstepien
reviewed
Feb 23, 2026
| import GroupedRow from './GroupRow'; | ||
| import { defaultRenderRow } from './Row'; | ||
| import { rowFocusable, rowSelectedClassname } from './style/row'; | ||
| import SummaryRowComponent from './SummaryRow'; |
Collaborator
There was a problem hiding this comment.
Suggested change
| import SummaryRowComponent from './SummaryRow'; | |
| import SummaryRow from './SummaryRow'; |
| isTreeGrid: boolean; | ||
| } | ||
|
|
||
| export interface RenderSummaryRowProps<TRow, TSummaryRow = unknown> extends Pick< |
| renderRow?: Maybe<(key: Key, props: RenderRowProps<TRow, TSummaryRow>) => ReactNode>; | ||
| renderSummaryRow?: Maybe< | ||
| (key: Key, props: RenderSummaryRowProps<TRow, TSummaryRow>) => ReactNode | ||
| >; |
Collaborator
There was a problem hiding this comment.
Let's document all the user-facing changes in the README
| bottom: number | undefined; | ||
| lastFrozenColumnIndex: number; | ||
| selectedCellIdx: number | undefined; | ||
| isTop: boolean; |
Collaborator
There was a problem hiding this comment.
Should we remove isTop in favor of checking top/bottom?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.