Add column groups #3287
Merged
Add column groups #3287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
amanmahajan7
commented
Aug 15, 2023
src/GroupedColumnHeaderCell.tsx
Outdated
| const index = column.idx + 1; | ||
|
|
||
| function onClick() { | ||
| selectCell(column.idx); |
There was a problem hiding this comment.
We probably need to update cell selection logic to handle rowSpan also
|
Should we allow groups containing both frozen and unfrozen columns? |
Codecov Report
@@ Coverage Diff @@
## main #3287 +/- ##
==========================================
- Coverage 83.75% 83.13% -0.63%
==========================================
Files 45 47 +2
Lines 4568 4827 +259
Branches 717 752 +35
==========================================
+ Hits 3826 4013 +187
- Misses 742 814 +72
|
…ata-grid into am-column-groups
amanmahajan7
commented
Aug 24, 2023
nstepien
previously approved these changes
Aug 24, 2023
amanmahajan7
commented
Aug 24, 2023
src/GroupedColumnHeaderRow.tsx
Outdated
Comment on lines
56
to
58
| className={clsx(headerRowClassname, { | ||
| [rowSelectedClassname]: selectedCellIdx === -1 | ||
| })} |
There was a problem hiding this comment.
Suggested change
| className={clsx(headerRowClassname, { | |
| [rowSelectedClassname]: selectedCellIdx === -1 | |
| })} | |
| className={headerRowClassname} |
TreeDataGrid is not supported so may be we can remove it
| return { '--rdg-grid-row-start': rowIdx } as unknown as CSSProperties; | ||
| } | ||
|
|
||
| export function getHeaderCellStyle<R, SR>( |
There was a problem hiding this comment.
Worth updating this function to handle colSpan also?
There was a problem hiding this comment.
getCellStyle handles it already, so it'd duplicate the work for normal header cells 🤔
| } | ||
| ]; | ||
|
|
||
| test('grouping', () => { |
There was a problem hiding this comment.
We should also test that clicking on the group cell correctly selects it. We can do this when we fix cell navigation
nstepien
approved these changes
Aug 24, 2023
adityatoshniwal
pushed a commit
to pgadmin-org/react-data-grid
that referenced
this pull request
Jul 31, 2024
* Initial commit to support column groups * idk * calculated groups * progress * progress * progress * remove level, fix header rows count * row span * fix incorrectly skipped headers * fix scrollPaddingBlock * Add `aria-rowspan` * add padding on top to move content at the bottom * fix colSpan * fix aria-rowspan * render grouped column header cells without duplicates * fix cell positions * remove `children` * disallow col groups in TreeDataGrid * fix test * add grouping test * tweak * dedupe headerRowsHeight * Remove TODO * Fix cell click selection on the column group * grouping -> row grouping * add col grouping page * revert common features * simplify getHeaderCellStyle * Fix params * add headerCellClass on ColumnGroup * group the Or types * remove TODO, add summary rows in the example * export CalculatedColumnParent and CalculatedColumnOrColumnGroup * minor tweaks * Combine `useMoreCalculatedColumnsStuff` and `useCalculatedColumns` * tweaks * consistent gridColumnEnd * fix tests * rm rowSelectedClassname usage * fix cell borders --------- Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com> Co-authored-by: Nicolas Stepien <stepien.nicolas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.