-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ReplaySubject and Publisher.share(replay:) #23
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 96.94% 97.14% +0.19%
==========================================
Files 34 38 +4
Lines 1638 2066 +428
==========================================
+ Hits 1588 2007 +419
- Misses 50 59 +9
Continue to review full report at Codecov.
|
ReplaySubject
and Publisher.share(replay)
.ReplaySubject
and Publisher.share(replay:)
.
Glad it’s been useful! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't go over the tests yet, I'll do that later locally,
Most of the notes are just formatting, nothing logic-wise except 1 question
Great work! 👏
Co-Authored-By: Shai Mishali <freak4pc@gmail.com>
Co-Authored-By: Shai Mishali <freak4pc@gmail.com>
Co-Authored-By: Shai Mishali <freak4pc@gmail.com>
Should be good for another pass over, thanks for the thorough review, Shai. 🙏🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second pass, this should be everything I have in mind ;)
Sorry for the lengthy review but this is a big piece of code with 2 very useful features :) Thanks!
Aaand round-two feedback incorporated. 🤞🏽 Thanks again for the reads over this! |
ReplaySubject
and Publisher.share(replay:)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last note!!
Co-Authored-By: Shai Mishali <freak4pc@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
h/t to @tcldr for the reference implementation I leaned on and adapted to Shai’s
DemandBuffer
type. 💯