Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: NSObject Publisher #88

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

viewDidAppear
Copy link

Closes #50

Full credit to @maximkrouk. I pulled his changes and rewound them onto the current master build with some tiny tweaks - notably retaining Runtime naming for the framework, and keeping "Interception" related code inside CombineCocoa's main directory.

@@ -0,0 +1,167 @@
//

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This folder (Sources/CombineCocoa/Interception) is actually a port of ReactiveCocoa code, so maybe it is worth mentioning them in Readme/Credits/Acknowledgements

@maximkrouk
Copy link

maximkrouk commented Jul 27, 2023

Plus as you already saw that I made https://github.com/capturecontext/combine-interception, which implements this feature and will allow you to plug-in this feature locally

Pros of adding it to CombineCocoa:

  • It becomes a part of a big CombineCommunity org

Cons:

  • It's not actually Cocoa-related, CombineExt seems like a more suitable place for this feature
  • It may conflict with other implementations

I'm a naming nerd so I have my own combine extensions (wip), but the initial reason I made it, is at least to import gh/combine-extensions instead of gh/CombineExt 🤡

However I have another wip project combine-cocoa-navigation, and for now it's (my) combine-extensions-dependent, but if we keep this feature as a separate package I can remove my dependency and this navigation package will be available for those who use CombineExt too 👍.

I'm not sure if @freak4pc will be down to depend on my lib, if not, maybe it is worth to create a separate repo in this org anyway to transfer https://github.com/capturecontext/combine-interception to CombineCommunity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FeatureRequest: Add handlers for selectors
2 participants