-
Notifications
You must be signed in to change notification settings - Fork 13
Description
I took a look and this is great work.
The single issue I see is that when you use install_name_tool to change the references to the dylibs you are using absolute paths.
This means, of course, your pre-built binaries do not work. Instead errors like this are printed:
dyld[37761]: Library not loaded: /Users/runner/work/FFmpeg-macOS/FFmpeg-macOS/ffmpeg/install_universal/lib/libavdevice.59.dylib
Using that dylib as an example and realizing this applies to all the dylibs.
You can fix this by using @executable-path/../bin/libavdevice.59.dylib, to make the dylib paths relative to the main executable rather than being absolute paths from your build. Where dylibs reference other dylibs I think its the same but you would need to verify that as I have never split the bin and lib when I do this.
When I do this I put the bin and lib in the same folder and then use @executable-path/libavdevice.59.dylib for all the references everywhere.
But otherwise, fantastic work.