nuke #10
nuke #10
Conversation
- launchfornuke.py support in nuke
- README.md add create nuke menu description
…d if it does not exist, the menu will be created
…to nuke # fix Conflicts: # python/scriptsmenu/action.py # python/scriptsmenu/launchformaya.py # python/scriptsmenu/scriptsmenu.py
README.md
Outdated
| @@ -33,10 +33,12 @@ menu = ScriptsMenu(title="Scripts", | |||
| menu.add_script(parent=menu, | |||
| title="Script A", | |||
| command="print('A')", | |||
| sourcetype='', | |||
There was a problem hiding this comment.
Well spotted, this should've been fixed in the README. Though I don't believe an empty string is the fix we're looking for. This should be sourcetype="python"
There was a problem hiding this comment.
Ok. I get it, Thank you.
python/scriptsmenu/action.py
Outdated
| @@ -112,7 +112,7 @@ def run_command(self): | |||
| callback(self) | |||
| return | |||
|
|
|||
| exec(self.process_command()) | |||
| exec (self.process_command()) | |||
There was a problem hiding this comment.
Any particular reason you strayed away from PEP08 and added the space?
There was a problem hiding this comment.
OK, later I can check my settings, maybe is fix conflicts lost something
|
@loonghao Great! :) I made two line comments regarding changes, aside from that this is looking great. Thanks for this! Will you be using this in production? |
|
@BigRoy Not yet, just for myself. |
Feel free to create any issues if you're looking for specific features. |
|
Ok, cool |
|
@BigRoy can you help me, merger this PR? |
|
Sure can, will have a look first thing tomorrow. |
|
Some minor notes still:
|
update version.py version:1.2.0
|
@BigRoy already fix |
support nuke