Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing guild role fields to support newer Discord API features. The changes expand the guild role model to include additional properties like colors, icons, tags, and flags that were previously missing from the implementation.
- Adds new role color system with primary, secondary, and tertiary colors
- Implements role tags structure for bot roles, integrations, and premium features
- Adds role flags enum and icon/emoji support
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| DiscordGuildRoleData.cs | Extended with new properties for icons, colors, tags, and flags |
| DiscordGuildRole.cs | Updated constructor and properties to handle new role fields |
| DiscordGuildRoleColorsData.cs | New data model for role color structure |
| DiscordGuildRoleTagsData.cs | New data model for role tags with custom converter |
| DiscordGuildRoleFlags.cs | New enum for role flags |
| Various test JSON files | Updated test data to include new role properties |
src/Color-Chan.Discord.Core/Common/API/DataModels/Guild/DiscordGuildRoleColorsData.cs
Outdated
Show resolved
Hide resolved
src/Color-Chan.Discord.Core/Common/API/DataModels/Guild/DiscordGuildRoleColorsData.cs
Outdated
Show resolved
Hide resolved
src/Color-Chan.Discord.Core/Common/API/DataModels/Guild/DiscordGuildRoleColorsData.cs
Outdated
Show resolved
Hide resolved
src/Color-Chan.Discord.Core/Common/Models/Guild/IDiscordGuildRole.cs
Outdated
Show resolved
Hide resolved
src/Color-Chan.Discord.Core/Common/API/Converters/DiscordGuildRoleTagsDataConverter.cs
Outdated
Show resolved
Hide resolved
src/Color-Chan.Discord.Core/Common/API/Converters/DiscordGuildRoleTagsDataConverter.cs
Outdated
Show resolved
Hide resolved
src/Color-Chan.Discord.Core/Common/API/Converters/DiscordGuildRoleTagsDataConverter.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Marks
DiscordGuildRoleData.Coloras obsolote because it is now replaced bycolors.Screenshots (if appropriate):
Types of changes
Checklist: