Feature/90 disambiguate first index of #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added some documentation to various methods
hctrdev
reviewed
Nov 4, 2021
| public static int FirstIndexOfZeroBased<T>(this IEnumerable<T> values, T value) => | ||
| values.FirstIndexOf(value, 0); | ||
|
|
||
| public static int FirstIndexOf<T>(this IEnumerable<T> values, T value, int startIndex) |
Collaborator
There was a problem hiding this comment.
The name startIndex is a bit confusing in this context. At first glace I thought it was the index where the search starts (i.e. if you say the start index is 5, it will start looking for a match at position 5 of the array).
StartIndex can confuse the user that it's the index at which to start the search
hctrdev
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored various indexing functions on the IEnumerable extension and the OneBasedArray class to disambiguate between zero-based and one-based indexing.