Feature/write one d to two d array #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… methods for 2D Array extension and 2D array extension methods & associated tests are in separate classes now There are 2 new untested write operations available as 2D array extension methods Some other minor tidying up done e.g. moving the Enum to its own class
Negative and positive offsets are now allowed The For loop will only iterate over allowable values
This was
linked to
issues
Jun 8, 2020
…rray Before, they were only checking that the column written to was correct Now, they ensure the entire resultant array is as expected This gives the extra protection of ensuring writes aren't happening to the wrong row/column
There's no point in testing all these cases again - they're already tested in 0-based case
Also fixed nullable annotations in existing code to get rid of that warning
Added this as part of a new test class which can also be used for regular tests later
hctrdev
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.