Feature/curry dictionary updates #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling on the prefix method now and just checking the arity beforehand
hctrdev
requested changes
Feb 1, 2021
| public abstract NonnegativeInteger Arity { get; } | ||
| public abstract IEnumerable<IList<TKey>> Keyset(); | ||
|
|
||
| public IEnumerable<(IList<TKey>, TVal)> KeyValuePairs() => |
Collaborator
There was a problem hiding this comment.
I think it is worth adding a couple of tests for these new methods (KeyValuePairs and Values). Just to make sure they return the expected keys and do not fail on empty dictionaries.
| TVal this[params TKey[] keyTuple] { get; } | ||
| IEnumerable<IList<TKey>> Keyset(); | ||
| IEnumerable<(IList<TKey>, TVal)> KeyValuePairs(); | ||
| IEnumerable<TVal> Values(); |
Collaborator
There was a problem hiding this comment.
Should these be methods or properties? The standard C# dictionaries expose Keys and Values as properties. Is there a particular reason you made these methods instead?
Owner
Author
There was a problem hiding this comment.
Yeah I originally had Keys as a property, but it felt like a lie to the user as the enumeration was walking through each individual item... However, I suppose that's the way for most enumerable properties... I'll change em to properties so
Added tests for empty dictionary case Added tests for checking enumerables after adding known entries
hctrdev
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed bug in the
ContainsKeyTuplemethod