Feature/curry dictionary #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a version for params and IEnumerable for all applicable functions Reordered functions in a standard way
Some are just stubs in advance of unit testing
Closed
C# 9 only supported by .NET 5 and above
…ndal/CsharpExtras into feature/curry-dictionary
Returning null tuple instead of tuple containing default Default causes a warning due to potential nullability Fixed bug in FindFirstOccurrenceOfSet for ArrayExtension - indices were zero based and were indexing up to length Note - FindFirstOccurrenceOfSet is different for OneBased vs. ZeroBased arrays For one-based, it is inclusive of both upper and lower bounds For zero-based, it excludes the upper bound
hctrdev
requested changes
Jan 29, 2021
| IOneBasedArray<TVal> ZipMulti<TOther>(Func<TVal, TOther, TVal> zipper, IOneBasedArray<TOther> other, params IOneBasedArray<TOther>[] extras); | ||
| (int index, TVal element) FindFirstOccurrenceOfSet(ISet<TVal> set); | ||
| (int index, TVal element) FindFirstOccurrenceOfSet(ISet<TVal> set, int startIndex, int endIndex); | ||
| (int index, TVal element)? FindFirstOccurrenceOfSet(ISet<TVal> set); |
Collaborator
There was a problem hiding this comment.
Add this breaking change to the CHANGELOG file.
Moved changelog entry to correct location Did some renaming Fixed minor inconsistency in FindFirstOccurrenceOfSet by removing +1 Removed unimiplemented setter property on curry dictionary
hctrdev
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added curry dictionary type and tests. This dictionary type nested dictionaries using tuples of keys and allows currying i.e. applying only a prefix of the keys or checking a prefix of keys for existence. The advantage is that prefixes can be queried with a complexity that is linear in the size of the key tuples only, but is constant w.r.t. the number of entries in the dictionary.