Skip to content

Conversation

@ilusi0n
Copy link
Contributor

@ilusi0n ilusi0n commented Jun 12, 2020

Description

Adding unit tests to the Bool Extension

Closes #19

Copy link
Owner

@ColmBhandal ColmBhandal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are excellent tests! Just one change I request: change all the var types to explicit types. This is just one of our coding conventions: https://github.com/ColmBhandal/CsharpExtras/blob/master/CONTRIBUTING.md

@ilusi0n
Copy link
Contributor Author

ilusi0n commented Jun 13, 2020

These are excellent tests! Just one change I request: change all the var types to explicit types. This is just one of our coding conventions: https://github.com/ColmBhandal/CsharpExtras/blob/master/CONTRIBUTING.md

Sorry, I guess I missed that one. Fixed now. Thank you!

@ilusi0n ilusi0n requested a review from ColmBhandal June 13, 2020 10:47
@ColmBhandal
Copy link
Owner

These are excellent tests! Just one change I request: change all the var types to explicit types. This is just one of our coding conventions: https://github.com/ColmBhandal/CsharpExtras/blob/master/CONTRIBUTING.md

Sorry, I guess I missed that one. Fixed now. Thank you!

You didn't miss it :) I only added the guideline this morning. Our guidelines are still a WIP. We'll just be adding as we go :)

@ColmBhandal ColmBhandal merged commit 3660bf9 into ColmBhandal:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit tests for BoolExtension

2 participants