Feature/zip fold #137
Merged
Feature/zip fold #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Fold" gives the wrong impression that we are folding a binary operation
hctrdev
requested changes
Feb 21, 2022
| /// in all the arrays.</returns> | ||
| public static TResult[,] ZipEnum<TVal, TOther, TResult>(this TVal[,] array, Func<TVal, IEnumerable<TOther>, TResult> zipper, IEnumerable<TOther[,]> others) | ||
| { | ||
| int minRows = others.Select(o => o.GetLength(0)).UnionMin(array.GetLength(0).AsSingleton()); |
Collaborator
There was a problem hiding this comment.
Would it be possible to do the .Union first and then a Min?
Something like:
others.Select(o => o.GetLength(0)).Union(array.GetLength(0)).Min();
Or even:
others.Union(array).Select(o => o.GetLength(0)).Min();
It might be slightly clearer and more standard. The same applies to the other places that use this format.
Removed Union Min extension function Marked union max as obsolete & specified to use Union followed by Max for this
hctrdev
previously approved these changes
Feb 21, 2022
hctrdev
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added 4
ZipEnummethods on one/zero-based arrays and their 2D equivalents. Added unit tests for all. Also extendedIEnumerablewith some supporting extension methods.TODO