Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces significant enhancements to the theme system and media handling capabilities, focusing on improved customization options and better control over media display in essays. The changes enable users to choose between essay and monograph base themes, customize image display styles, and control whether media opens in a spotlight viewer or links directly to item pages.
Key changes:
- Added new theme configuration options including base theme selection (essay/monograph), font customization, and featured image display styles
- Implemented a sophisticated spotlight media handler that supports multiple media types (YouTube, Vimeo, MP4, MP3, PDF) with gallery navigation
- Enhanced aside and image components with a new
galleryparameter to control media interaction behavior
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| _data/theme.yml | Reorganized and expanded theme configuration with new base-theme, font, and image-style options |
| _layouts/essay-content.html | Added custom footer script for spotlight handler and previous/next navigation buttons |
| _layouts/default.html | Updated side-nav visibility logic to support monograph theme |
| _includes/essay/side-nav.html | Refactored to support both essay and monograph themes with conditional rendering |
| _includes/essay/off-canvas-menu.html | Extracted menu component for reuse across themes |
| _includes/essay/off-canvas-contents.html | New component for monograph theme table of contents navigation |
| _includes/essay/js/spotlight-media-handler.html | New JavaScript module for handling diverse media types in spotlight viewer |
| _includes/essay/feature/image-gallery.html | Enhanced to support both direct image URLs and objectid-based gallery items |
| _includes/essay/feature/image-aside.html | Added gallery parameter for controlling link behavior and improved non-image media display |
| _includes/essay/feature/aside.html | Added gallery parameter support for media asides |
| _sass/_essay.scss | Changed button link color from green to dark blue |
| _sass/_custom.scss | Added custom spotlight viewer styling for item page buttons and responsive layout |
| assets/data/metadata.json | Added objectid, display_template, and image_small fields to metadata export |
| _essay/of-sleep.md | Enhanced with additional asides using new gallery parameter |
| _essay/of-a-monstrous-child.md | Standardized title casing and updated byline |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # HOME PAGE | ||
| # | ||
| # featured image is defined above |
There was a problem hiding this comment.
Duplicate "HOME PAGE" section headers. Lines 22 and 37 both define "HOME PAGE" sections with similar comments. The structure should be reorganized to avoid this duplication and confusion about which section controls what.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
[WIP] Update Spotlight revision and theming options
This pull request introduces several improvements and refinements to the theme configuration and essay feature asides, with a focus on enhancing customization and user experience for media display. The most significant changes include expanded theme options, improved control over how media and asides are displayed, and minor metadata and content adjustments.
Theme and Configuration Enhancements:
_data/theme.ymlconfiguration with new options for base theme (essayormonograph), font customization, and featured image display style, providing greater flexibility in the site's appearance._data/theme.ymlto avoid duplication and potential confusion.Feature Aside and Media Display Improvements:
galleryparameter to theaside.htmlandimage-aside.htmlincludes, allowing asides and images to link either to the spotlight viewer or directly to the item page, improving accessibility and user control over media interaction. [1] [2]image-aside.htmlto respect the newgalleryparameter, ensuring consistent behavior for both images and non-image media types.Essay Content and Metadata Adjustments:
_essay/of-a-monstrous-child.mdand_essay/of-sleep.mdfor consistency. [1] [2]objectidreferences and the newgalleryparameter, enriching the reading experience with relevant media links.