-
-
Notifications
You must be signed in to change notification settings - Fork 75
Preview 1.83.3 #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview 1.83.3 #755
Conversation
100% reviewed source file: 'en_US.json' on 'fr_FR'.
100% reviewed source file: 'en_US.json' on 'ja_JP'.
https://nvd.nist.gov/vuln/detail/CVE-2025-26646 https://msrc.microsoft.com/update-guide/vulnerability/CVE-2025-26646 # Main Goal Update .NET SDK to 9.0.5 (9.0.300) to fix CVE (Score of 8.0/10.0) ## PR Status : - Overall Status : Done - Commits : Done - Synced to base (Collapse:main) : Yes - Build status : OK - Crashing : No - Bug found caused by PR : 0 ### Templates <details> <summary>Changelog Prefixes</summary> ``` **[New]** **[Imp]** **[Fix]** **[Loc]** **[Doc]** ``` </details>
100% reviewed source file: 'en_US.json' on 'zh_CN'.
Now the default values assignment only happens if correction is needed
Contains velopack code update, please review them carefully
Usually happen on debug/self-built builds
As far as I know, we dont use ADS and it might break certain file ops, so we strip it
- WASDK 1.8.250410001-experimental1 -> 1.8.250515001-experimental2 - Webview 1.0.3240.44 -> 1.0.3296-prerelease
This will still give that shadow missing asset, but a whole lot better than just stopping the repair altogether
oops...
- Velopack (0.0.1251 -> 0.0.1297) - Markdig.Signed (0.41.1 -> 0.41.2) - Sentry (5.9.0 -> 5.10.0)
that's why you don't code when your stomach is empty, kids...
Uh, idk what to put on the description here. But glad it work now (yay! [actually tired])
# Main Goal ## Update outdated dependencies - Microsoft.Windows.SDK.BuildTools (10.0.26100.3916 -> 10.0.26100.4188) - Velopack (0.0.1053 -> 0.0.1297) - Contains untested changes regarding Velopack API changes (cannot find the documentation site) - Please test/review carefully - Does tested pseudo-updating from generated build to preview 1.82.2 but yknow) - Sentry (5.6.0 -> 5.10.0) - Protobuf (3.30.0 -> 3.31.1) - WindowsAppSDK (1.8.250410001-experimental1 -> 1.8.250515001-experimental2) - Webview (1.0.3240.44 -> 1.0.3296-prerelease) - Markdig.Signed (0.41.1 -> 0.41.2) ## Version bump to 1.83.3 ## Small bug fixes - [Fix EnumFailedVersion in SpawnRegionNotification](d381562) d381562 - Fix #748 - [[GI] [Repair] Prevent repair from nuking the install](f616439) - GI repair falsely put directory as asset and tried to do FileInfo.Delete function that causes UnauthorizedAccessException, but scary anyway, so measure against it is in place. Repair wont delete any directory from now. - [Add image loading retry method](8d4a39c) 8d4a39c - Try fix #723 ## PR Status : - Overall Status : Done - Commits : Done - Synced to base (Collapse:main) : Yes - Build status : OK - Crashing : Yes - Bug found caused by PR : 0 - ~~LibZSTD is not linked inside NativeAOT build and still require a loose DLLs~~ - Fixed. Cause: DebugCIAOT was missing `AOT` build constant ### Templates <details> <summary>Changelog Prefixes</summary> ``` **[New]** **[Imp]** **[Fix]** **[Loc]** **[Doc]** ``` </details>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates core dependencies and .NET version, enhances Sophon download logic, and adds robust handling for alternate data streams and retry mechanisms.
- Fixes and improvements in Sophon asset management, including conditional additional package downloads
- Adds
StripAlternateDataStream
support across file operations - Introduces retry logic for image downloads and refactors Velopack logger/locator extensions
Reviewed Changes
Copilot reviewed 73 out of 73 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
InstallManagerBase.Sophon.cs | Expanded IsUseSophon logic and moved progress initialization |
InstallManagerBase.PkgVersion.cs | Included "ldiff" path in game file categorization |
LauncherUpdateHelper.cs | Streamlined exception filter and updated Velopack adapter usage |
StreamExtension.cs | Added ADS-stripping methods and integrated them in file utilities |
LauncherApiBase.cs | Early return when Sophon and ZIP versions match |
ImageLoaderHelper.cs | Added retry-on-failure with exponential backoff for resource fetch |
VersionCheck.cs | Enhanced install detection with alternate executable name |
GameVersionBase.IniConfig.cs | Simplified INI initialization signatures |
GameVersionBase.GameState.cs | Refactored IsGameInstalled into inner method |
Sleepy.cs | Applied ADS stripping to file writes |
VelopackLoggerExtension.cs & VelopackLocatorExtension.cs | Introduced extension methods for seamless Velopack integration |
UIElementExtensions.cs | Added optional opacity parameter to text runs |
DictionaryExtension.cs | New helper for case-insensitive dictionary lookups |
StarRail/Update.cs | Integrated ADS stripping into cache updates |
CollapseLauncher.slnx | Reworked project path separators and removed GUIDs in solution file |
.github/workflows/*.yml | Bumped .NET installer version from 9.0.2xx to 9.0.3xx |
Comments suppressed due to low confidence (4)
CollapseLauncher/Classes/Helper/Image/ImageLoaderHelper.cs:625
- [nitpick] Private static fields typically use
_camelCase
(e.g.,_urlRetryCount
) to distinguish them from public members and improve readability.
private static ConcurrentDictionary<string, int> UrlRetryCount = new();
CollapseLauncher/Classes/Helper/StreamUtility/StreamExtension.cs:217
- [nitpick] Using a large, complex regex in an attribute can hinder readability. Consider extracting the pattern into a well-named constant and referencing it here.
[GeneratedRegex("^(?<path>[a-zA-Z]:\\(?:[^\\/:*?\"<>|\r\n]+\\)*[^\\/:*?\"<>|\r\n]+)(:[^\\/:*?\"<>|\r\n]+)$", RegexOptions.Compiled, 10000)]
CollapseLauncher.slnx:8
- The solution file no longer includes the project GUID and uses forward slashes, which may break project loading in Visual Studio. Restore the original GUID attributes and backslashes or ensure compatibility with the editor.
<Project Path="CollapseLauncher/CollapseLauncher.csproj">
CollapseLauncher/Classes/Extension/VelopackLoggerExtension.cs:7
- Class declaration syntax is invalid; constructors cannot be declared in the class signature. Define a proper constructor inside the class body or switch to
record
syntax if using positional parameters.
public class VelopackLoggerAdaptor(ILogger logger) : IVelopackLogger
+ Also, removing unused AI-related library (Thanks Microsoft for taking so much waste)
|
100% reviewed source file: 'en_US.json' on 'es_419'.
What's changed?
config.ini
on initialization, by @neon-nyan