Animate view switcher on formatting shortcuts in view mode#15408
Merged
Conversation
banobepascal
force-pushed
the
private/banobepascal/viewmode-keystrokes
branch
2 times, most recently
from
8bb291d to
9cdfe0a
Compare
banobepascal
force-pushed
the
private/banobepascal/viewmode-keystrokes
branch
from
9cdfe0a to
2a88280
Compare
Comment on lines
+343
to
+346
| new ShortcutDescriptor({ eventType: 'keydown', modifier: Mod.CTRL, key: 'b', unoAction: '.uno:Bold' }), | ||
| new ShortcutDescriptor({ eventType: 'keydown', modifier: Mod.CTRL, key: 'i', unoAction: '.uno:Italic' }), | ||
| new ShortcutDescriptor({ eventType: 'keydown', modifier: Mod.CTRL, key: 'u', unoAction: '.uno:Underline' }), | ||
|
|
Contributor
There was a problem hiding this comment.
does this work on a mac?
Contributor
Author
There was a problem hiding this comment.
Yes this works on Mac both Safari and Chome
Here is a screenplay on safari
Online.webm
- Registers formatting shortcuts like Ctrl+B, Ctrl+I, and Ctrl+U globally so they are always intercepted, even when in viewmode. - Prevents the browser’s default actions (like opening sidebars or page source) and, in view mode, triggers the view mode switcher animation instead of silently ignoring the input. Signed-off-by: Banobe Pascal <banobe.pascal@collabora.com> Change-Id: I6b827a51d71f4cc903e60ca38615a6a30e9545d5
banobepascal
force-pushed
the
private/banobepascal/viewmode-keystrokes
branch
from
2a88280 to
3a86562
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I6b827a51d71f4cc903e60ca38615a6a30e9545d5
Summary
Registers formatting shortcuts like Ctrl+B, Ctrl+I, and Ctrl+U globally so they are always intercepted, even when in viewmode.
Prevents the browser’s default actions (like opening sidebars or page source) and, in view mode, triggers the view mode switcher animation instead of silently ignoring the input.
PREVIEW
online-view.mp4